Added Prisma TypedSQL #377
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
![ellipsis-dev[bot]](https://avatars.githubusercontent.com/in/64358?s=60&v=4){kind=small}
N2D4
requested changes
Dec 24, 2024
| "codegen-prisma": "pnpm run prisma generate", | ||
| "codegen-prisma:watch": "pnpm run prisma generate --watch", | ||
| "codegen": "pnpm run with-env bash -c 'if [ \"$STACK_ACCELERATE_ENABLED\" = \"true\" ]; then pnpm run prisma generate --no-engine && pnpm run generate-docs; else pnpm run codegen-prisma && pnpm run generate-docs; fi'", | ||
| "codegen-prisma": "concurrently -k -s first \"tsx scripts/mock-postgres.mjs\" \"node -e \\\"setTimeout(() => process.exit(0), 2000)\\\" && cross-env STACK_DATABASE_CONNECTION_STRING=\\\"postgres://postgres@localhost:8118/postgres?pgbouncer=true&connection_limit=1\\\" STACK_DIRECT_DATABASE_CONNECTION_STRING=\\\"postgres://postgres@localhost:8118/postgres?connection_limit=1\\\" STACK_SEED_INTERNAL_PROJECT_PUBLISHABLE_CLIENT_KEY=\\\"test_key\\\" STACK_SEED_INTERNAL_PROJECT_SECRET_SERVER_KEY=\\\"test_secret\\\" STACK_SEED_INTERNAL_PROJECT_SUPER_SECRET_ADMIN_KEY=\\\"test_admin\\\" sh -c \\\"pnpm run prisma migrate reset --force && pnpm run prisma generate --sql\\\"\"", |
There was a problem hiding this comment.
can we put this into a JS file instead (you can merge it with mock-postgres.mjs)
| "codegen": "pnpm run with-env bash -c 'if [ \"$STACK_ACCELERATE_ENABLED\" = \"true\" ]; then pnpm run prisma generate --no-engine && pnpm run generate-docs; else pnpm run codegen-prisma && pnpm run generate-docs; fi'", | ||
| "codegen-prisma": "concurrently -k -s first \"tsx scripts/mock-postgres.mjs\" \"node -e \\\"setTimeout(() => process.exit(0), 2000)\\\" && cross-env STACK_DATABASE_CONNECTION_STRING=\\\"postgres://postgres@localhost:8118/postgres?pgbouncer=true&connection_limit=1\\\" STACK_DIRECT_DATABASE_CONNECTION_STRING=\\\"postgres://postgres@localhost:8118/postgres?connection_limit=1\\\" STACK_SEED_INTERNAL_PROJECT_PUBLISHABLE_CLIENT_KEY=\\\"test_key\\\" STACK_SEED_INTERNAL_PROJECT_SECRET_SERVER_KEY=\\\"test_secret\\\" STACK_SEED_INTERNAL_PROJECT_SUPER_SECRET_ADMIN_KEY=\\\"test_admin\\\" sh -c \\\"pnpm run prisma migrate reset --force && pnpm run prisma generate --sql\\\"\"", | ||
| "codegen-prisma:watch": "pnpm run codegen-prisma && chokidar \"prisma/**/*\" -c \"pnpm run codegen-prisma\"", | ||
| "codegen": "pnpm run with-env bash -c 'if [ \"$STACK_ACCELERATE_ENABLED\" = \"true\" ]; then pnpm run prisma generate --sql --no-engine && pnpm run generate-docs; else pnpm run codegen-prisma && pnpm run generate-docs; fi'", |
There was a problem hiding this comment.
Why this change? Why prisma generate --sql when that environment variable is set, but pnpm run codegen-prisma otherwise?
apps/backend/src/instrumentation.ts
Outdated
There was a problem hiding this comment.
I was testing something, will put it back
| }) | ||
| }) | ||
|
|
||
| server.listen(8118, () => { |
There was a problem hiding this comment.
can you document this in the dev launchpad?
.dockerignore
Outdated
| @@ -57,6 +57,7 @@ packages/adapter-prisma/prisma/migrations | |||
| db.sqlite | |||
| packages/adapter-supabase/supabase/.branches | |||
| packages/adapter-drizzle/.drizzle | |||
| pglite-data/ | |||
There was a problem hiding this comment.
Suggested change
| pglite-data/ |
There was a problem hiding this comment.
pglite generates a folder automatically, a lot of files will be committed if we don't ignore it
.gitignore
Outdated
| @@ -58,6 +58,7 @@ packages/adapter-prisma/prisma/migrations | |||
| db.sqlite | |||
| packages/adapter-supabase/supabase/.branches | |||
| packages/adapter-drizzle/.drizzle | |||
| pglite-data/ | |||
There was a problem hiding this comment.
Suggested change
| pglite-data/ |
.dockerignore
Outdated
| @@ -136,4 +137,4 @@ node_modules | |||
|
|
|||
| deploy | |||
| !deploy/docker/**/entrypoint.sh | |||
| docker-compose.yaml | |||
| docker-compose.yaml | |||
There was a problem hiding this comment.
Suggested change
| docker-compose.yaml | |
| docker-compose.yaml | |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Important
Introduces Prisma TypedSQL, updates dependencies, and modifies SQL queries to use typed SQL in the backend.
codegen-prisma:watchscript inpackage.jsonto use--sqlflag.getUsersLastActiveAtMillisincrud.tsxto useprismaClient.$queryRawTypedwithgetUsersLastActiveAtMillisSql.@prisma/clientandprismato version^6.1.0inpackage.json.@electric-sql/pglite,chokidar-cli, andpg-gatewaytopackage.json.typedSqltopreviewFeaturesinschema.prisma.getUsersLastActiveAtMillis.sqlto handle user activity queries.mock-postgres.mjsto handle database connections usingPGlite.sentry.client.config.ts.This description was created by
for 259a780. It will automatically update as commits are pushed.